Add impersonation option in trino datasource #7605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimsehwan96
force-pushed
the
add-trino-impersonation-options
branch
from
4dab221 to
0e4731b
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
kimsehwan96
force-pushed
the
add-trino-impersonation-options
branch
from
0e4731b to
5d1e431
Compare
kimsehwan96
force-pushed
the
add-trino-impersonation-options
branch
from
5d1e431 to
c9dfe57
Compare
yoshiokatsuneo
approved these changes
Jan 24, 2026
Contributor
yoshiokatsuneo
left a comment
yoshiokatsuneo
left a comment
There was a problem hiding this comment.
I have not tested it.
But I believe I can approve it as:
- The PR author looks tested well.
- The changed code looks good.
- There is no test failure.
Contributor
|
Thank you for your contribution with detailed description ! |
Contributor
Author
|
@yoshiokatsuneo Thank you for the fast review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Add user impersonation support for Trino data source.
Background
Trino supports user impersonation, which allows query auditing and fine-grained access control by passing the actual user identity to Trino instead of a shared service account.
Changes
Configuration
Both options are available under "Additional Settings" in the data source configuration.
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)